[PATCH] D129557: [AMDGPU] Improve liveness copying in si-optimize-exec-masking-pre-ra

[Carl Ritson via Phabricator via llvm-commits]

critson marked an inline comment as done.
critson added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:194-195
+      CmpReg.isVirtual() ? &LIS->getInterval(CmpReg) : nullptr;
+  LiveInterval *SelLI =
+      SelReg.isVirtual() ? &LIS->getInterval(SelReg) : nullptr;
+
----------------
arsenm wrote:
> I'm increasingly worried about just ignoring physical registers. Is there a reason why we bother to try handling them here?
Thanks for pointing this out.
We don't need to handle physical register for SelReg anymore as do not optimize these anymore.
I've simplified the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129557/new/

https://reviews.llvm.org/D129557