[PATCH] D129557: [AMDGPU] Improve liveness copying in si-optimize-exec-masking-pre-ra

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:194-195
+      CmpReg.isVirtual() ? &LIS->getInterval(CmpReg) : nullptr;
+  LiveInterval *SelLI =
+      SelReg.isVirtual() ? &LIS->getInterval(SelReg) : nullptr;
+
----------------
I'm increasingly worried about just ignoring physical registers. Is there a reason why we bother to try handling them here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129557/new/

https://reviews.llvm.org/D129557