[PATCH] D128796: [SCCP] Simplify CFG in SCCP as well

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D128796#3645816 <https://reviews.llvm.org/D128796#3645816>, @cfang wrote:

> This patch triggered a correctness issue in running mixbench-ocl-alt.
> I am not familiar with the CFG in SCCP pass at all. But the comments 
> in the code seems suggest we should not change the CFG:
>
> // If we decided that there are basic blocks that are dead in this function,
> // delete their contents now.  Note that we cannot actually delete the blocks,
> // as we cannot modify the CFG of the function.

The comment should be irrelevant, the pass is not longer claiming to preserve the CFG, so that should be fine.  If there is an incorrect transformation happening, we would need a reproducer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128796/new/

https://reviews.llvm.org/D128796