[PATCH] D128796: [SCCP] Simplify CFG in SCCP as well

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 10:08:04 PDT 2022


cfang added a comment.

This patch triggered a correctness issue in running mixbench-ocl-alt.
I am not familiar with the CFG in SCCP pass at all. But the comments 
in the code seems suggest we should not change the CFG:

// If we decided that there are basic blocks that are dead in this function,
// delete their contents now.  Note that we cannot actually delete the blocks,
// as we cannot modify the CFG of the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128796/new/

https://reviews.llvm.org/D128796



More information about the llvm-commits mailing list