[PATCH] D129544: [RISCV][test] Add test of binop followed by extractelement.

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/required changes before commit.



================
Comment at: llvm/test/CodeGen/RISCV/rvv/extractelt-fp-rv32.ll:485
+
+define float @ext_fadd_nxv4f32(<vscale x 4 x float> %x) {
+; CHECK-LABEL: ext_fadd_nxv4f32:
----------------
Naming wise, "ext" makes me think "extend" not "extractelement".

I'd suggest extractelt_<type>_<op>_splat.  


================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-extract.ll:653
+; CHECK-NEXT:    ret
+  %bo = mul <4 x i32> %x, <i32 1, i32 2, i32 3, i32 42>
+  %ext = extractelement <4 x i32> %bo, i32 3
----------------
Meta comment: "1" and "0" are special edge cases for mul and div.  Please use a constant which is not an edge case if you're not testing that behavior.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-extract.ll:662
+; CHECK-NEXT:    vsetivli zero, 0, e32, m1, ta, mu
+; CHECK-NEXT:    vmv.x.s a0, v8
+; CHECK-NEXT:    ret
----------------
Example of previous comment causing less than helpful test output.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129544/new/

https://reviews.llvm.org/D129544