[PATCH] D129544: [RISCV][test] Add test of binop followed by extractelement.
Jianjian Guan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 12 02:04:31 PDT 2022
jacquesguan added a comment.
In D129544#3644527 <https://reviews.llvm.org/D129544#3644527>, @frasercrmck wrote:
> I've only briefly looked at `shouldScalarizeBinop` but it sounds like it should theoretically work for scalable vectors (barring an initial check against `BUILD_VECTOR`) - should we add some scalable-vector tests here too while we're at it? I don't know if you're planning on that change in the future but having consistency sounds desirable to me. Or at least we could make it clear this patch adds fixed-vector tests.
Thanks for advice, I added scalable cases. And yes, it could work on scalable vectors too, I am doing the next patch which changes the DAGCombiner to enable these combinations for scalable vectors.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129544/new/
https://reviews.llvm.org/D129544
More information about the llvm-commits
mailing list