[PATCH] D129519: [Symbolizer] Implement contextual symbolizer markup elements.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-symbolizer.rst:254-255
   :doc:`Symbolizer Markup </SymbolizerMarkupFormat>` into human-readable form,
   and prints the results to standard output. Presently, only the following
   markup elements are supported:
 
----------------
The term "only" implies there are many other elements that aren't supported (at least more than the number of supported elements). Is that still the case? If not, delete "only".


================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/MarkupFilter.h:68
+
+    // The text and SGR nodes that preceeded the module element.
+    SmallVector<MarkupNode> MarginNodes;
----------------



================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/MarkupFilter.h:118
+
+  // Current line being filtered
   StringRef Line;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129519/new/

https://reviews.llvm.org/D129519