[PATCH] D129519: [Symbolizer] Implement contextual symbolizer markup elements.

[Daniel Thornburgh via Phabricator via llvm-commits]

mysterymath added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/MarkupFilter.h:128-129
+
+  std::map<uint64_t, Module> Modules;
+  std::map<uint64_t, MMap> MMaps;
 };
----------------
phosek wrote:
> I'd recommend using `DenseMap` which is more performant than `std::map`.
For Modules, it's desirable that Module pointers should be stable; this allows module IDs to be looked up once during parsing, then the resulting pointers stored indefinitely. But this is better done via a DenseMap to unique_ptr, so I've done so.

For MMaps, the collection is ordered by address, and this is used to quickly identify overlapping MMap regions. This isn't obvious though, so I've added a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129519/new/

https://reviews.llvm.org/D129519