[PATCH] D129179: [RISCV] Extend use of SHXADD instructions in RVV spill/reload code.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 09:47:06 PDT 2022


frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:1822
+    if (ShiftAmount) {
+      Register ShiftResReg = MRI.createVirtualRegister(&RISCV::GPRRegClass);
+      BuildMI(MBB, II, DL, get(RISCV::SLLI), ShiftResReg)
----------------
craig.topper wrote:
> Do we need a new GPR here?
And if we do need a new GPR, can we guarantee we don't need an extra emergency spill slot?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129179/new/

https://reviews.llvm.org/D129179



More information about the llvm-commits mailing list