[PATCH] D126423: github: Automatically assign reviewers for backport requests
Tom Stellard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 11 09:18:14 PDT 2022
tstellar added inline comments.
================
Comment at: llvm/utils/git/github-automation.py:235
+ def issue_request_review(self, commits:List[str]):
+ """
----------------
kwk wrote:
> tstellar wrote:
> > thieta wrote:
> > > kwk wrote:
> > > > When I use capital `L` I get: `NameError: name 'List' is not defined. Did you mean: 'list'?`
> > > List is a typing hint. You need to import it from the typing module.
> > When I use list[str], I get:
> >
> > TypeError: 'type' object is not subscriptable
> I think this is deprecated since Python 3.9 (https://docs.python.org/3/library/typing.html#typing.List). And this whole discussion rings a bell. @tstellar weren't the Github runners running an older version than what was required for `list[str]` to work?
@kwk Yes, I believe we ran into the same issue on another patch. I see we use List one other place in the patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126423/new/
https://reviews.llvm.org/D126423
More information about the llvm-commits
mailing list