[PATCH] D126423: github: Automatically assign reviewers for backport requests

[Konrad Wilhelm Kleine via Phabricator via llvm-commits]

kwk added inline comments.


================
Comment at: llvm/utils/git/github-automation.py:235
 
+    def issue_request_review(self, commits:List[str]):
+        """
----------------
tstellar wrote:
> thieta wrote:
> > kwk wrote:
> > > When I use capital `L` I get: `NameError: name 'List' is not defined. Did you mean: 'list'?`
> > List is a typing hint. You need to import it from the typing module. 
> When I use list[str], I get:
> 
> TypeError: 'type' object is not subscriptable
I think this is deprecated since Python 3.9 (https://docs.python.org/3/library/typing.html#typing.List). And this whole discussion rings a bell. @tstellar weren't the Github runners running an older version than what was required for `list[str]` to work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126423/new/

https://reviews.llvm.org/D126423