[PATCH] D129323: [llvm] add ztsd compression namespace

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 14:45:53 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Support/Compression.h:48
+
+static constexpr int NoCompression = -5;
+static constexpr int BestSpeedCompression = 1;
----------------
leonardchan wrote:
> nit: perhaps this could be an enum with assigned values?
Just use `constexpr`. They are automatically internal linkage


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129323/new/

https://reviews.llvm.org/D129323



More information about the llvm-commits mailing list