[PATCH] D129297: [LSR] Fix bug - check if loop has preheader before calling isInductionPHI

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 11:54:18 PDT 2022


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:1249
 
+bool checkIsIndPhi(PHINode *Phi, Loop *L, ScalarEvolution *SE,
+                   InductionDescriptor &ID) {
----------------
Meinersbur wrote:
> Please add a doxygen comment briefly describing what this is checking.
This comment is not done yet. Please mark `checkIsIndPhi` as having `static` linkage.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129297/new/

https://reviews.llvm.org/D129297



More information about the llvm-commits mailing list