[PATCH] D129297: [LSR] Fix bug - check if loop has preheader before calling isInductionPHI

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 11:53:46 PDT 2022


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:1257-1259
+  if (!InductionDescriptor::isInductionPHI(Phi, L, SE, ID))
+    return false;
+  return true;
----------------
could these three statements simply be:
```
return InductionDescriptor::isInductionPHI(Phi, L, SE, ID));
```
?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129297/new/

https://reviews.llvm.org/D129297



More information about the llvm-commits mailing list