[PATCH] D127488: [GlobalISel][DebugInfo] Remove debug info with zero line from constants inserted at entry block

Thu Jul 7 11:53:04 PDT 2022

aemerson added a comment.

In D127488#3636630 <https://reviews.llvm.org/D127488#3636630>, @dblaikie wrote:

> In D127488#3636496 <https://reviews.llvm.org/D127488#3636496>, @aemerson wrote:
>
>> I originally made constants use line 0 because on D63286 <https://reviews.llvm.org/D63286> Adrian said that if we don't emit 0, the constants end up being interpreted as being part of the prologue, which they're technically not.
>
> Though it doesn't look like @aprantl thought this would be bad - just that it would happen. Do you/we/anyone have any particular reason to believe it would be bad/problematic if thees instructions became part of the prologue?

I don't know of any reason why it would be bad, but admittedly I'm not an expert in this area. The original intention of using zero was to avoid unnecessary unintended effects. If we do have an issue here with the debug info sizes then I'm ok with removing them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127488/new/

https://reviews.llvm.org/D127488