[PATCH] D127488: [GlobalISel][DebugInfo] Remove debug info with zero line from constants inserted at entry block

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D127488#3636496 <https://reviews.llvm.org/D127488#3636496>, @aemerson wrote:

> I originally made constants use line 0 because on D63286 <https://reviews.llvm.org/D63286> Adrian said that if we don't emit 0, the constants end up being interpreted as being part of the prologue, which they're technically not.

Though it doesn't look like @aprantl thought this would be bad - just that it would happen. Do you/we/anyone have any particular reason to believe it would be bad/problematic if thees instructions became part of the prologue?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127488/new/

https://reviews.llvm.org/D127488