[PATCH] D129151: [Metadata] Add 'exclude' metadata to add the exclude flags on globals

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/docs/LangRef.rst:6411
+
+  @object = private constant [1 x i8] c"\00", section ".foo" !exclude !0
 
----------------
The argument (!0) is not described.


================
Comment at: llvm/lib/Transforms/Utils/ModuleUtils.cpp:284
   MD->addOperand(llvm::MDNode::get(Ctx, MDVals));
+  GV->setMetadata(LLVMContext::MD_exclude, llvm::MDNode::get(Ctx, MDVals));
 
----------------
Test this in the files that should be affected.


================
Comment at: llvm/test/CodeGen/X86/offload_sections.ll:7
 
+!0 = !{ptr @llvm.embedded.object, !".llvm.offloading"}
+
----------------
Unclear why exclude references the embedded object metadata here. What does that mean?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129151/new/

https://reviews.llvm.org/D129151