[PATCH] D129151: [Metadata] Add 'exclude' metadata to add the exclude flags on globals

[James Henderson via Phabricator via llvm-commits]

jhenderson resigned from this revision.
jhenderson added a comment.

Spotted a couple of minor issues in the docs, but otherwise, I don't have the knowledge to review this.



================
Comment at: llvm/docs/LangRef.rst:6400
+'``exclude``' Metadata
+^^^^^^^^^^^^^^^^^^^^^^^
+
----------------
Nit: the underline is too long here, and will probably cause a doc build warning.


================
Comment at: llvm/docs/LangRef.rst:6405
+option is only valid for global variables with an explicit section targeting ELF
+or COFF.This is done using the ``SHF_EXCLUDE`` flag on ELF targets and the
+``IMAGE_SCN_LNK_REMOVE`` and ``IMAGE_SCN_MEM_DISCARDABLE`` flags for COFF
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129151/new/

https://reviews.llvm.org/D129151