[PATCH] D120481: [AArch64] Try to re-use extended operand for SETCC with v16i8 operands.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 442777.
fhahn marked 3 inline comments as done.
fhahn added a comment.

In D120481#3632283 <https://reviews.llvm.org/D120481#3632283>, @dmgreen wrote:

> This sounds good as far as I can tell. If we are dealing with a dag combine, do we need to worry about odd types at all?

Do you mean worry in terms of whether it is optimal? There are a few test cases with odd types, and it seems like they are handled OK on that front.

> And I think we can include eq and ne too, if alive is to be believed.

Thanks, I added support for EQ/NE. The type of extend shouldn't matter, as long as we chose the existing one.

- sext EQ https://alive2.llvm.org/ce/z/5upBvb
- sext NE https://alive2.llvm.org/ce/z/zbEcJp
- zext EQ https://alive2.llvm.org/ce/z/_xMwof
- zext NE https://alive2.llvm.org/ce/z/5FwKfc


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120481/new/

https://reviews.llvm.org/D120481

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/test/CodeGen/AArch64/vselect-ext.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120481.442777.patch
Type: text/x-patch
Size: 16796 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220707/fb16b56d/attachment.bin>