[PATCH] D129037: [globalisel] Select register bank for DBG_VALUE

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp:734
+          if (!Ty.isValid()) {
+            Ignore = true;
+            break;
----------------
arsenm wrote:
> I wouldn't assume if one operand doesn't need assignment, then none do. Treat each operand individually
Yes, I agree, but this patch just to be conservative to constrain the logic in handling debug instruction, so that it can avoid causing much regression.
I think inline assembly also has such issue, because it may be mixed with physical register and virtual register.
How about adding a TODO here, so that we can improve it in another patch that handle the physical register or register that is assigned register class in underlying code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129037/new/

https://reviews.llvm.org/D129037