[PATCH] D129213: [MachineVerifier] Try harder to verify LiveVariables
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 6 08:26:28 PDT 2022
foad created this revision.
Herald added subscribers: jsji, kosarev, pengfei, hiraditya, tpr.
Herald added a project: All.
foad requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Verify the LiveVariables analysis after a pass that claims to preserve
it, even if there are no further passes (apart from the verifier itself)
that would use the analysis.
FIXME: CodeGen/AMDGPU/mul24-pass-ordering.ll fails with:
- Bad machine code: LiveVariables: Block should not be in AliveBlocks ***
FIXME: X86 tests fail with:
- Bad machine code: Kill missing from LiveVariables ***
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D129213
Files:
llvm/lib/CodeGen/MachineVerifier.cpp
Index: llvm/lib/CodeGen/MachineVerifier.cpp
===================================================================
--- llvm/lib/CodeGen/MachineVerifier.cpp
+++ llvm/lib/CodeGen/MachineVerifier.cpp
@@ -293,6 +293,7 @@
}
void getAnalysisUsage(AnalysisUsage &AU) const override {
+ AU.addUsedIfAvailable<LiveVariables>();
AU.setPreservesAll();
MachineFunctionPass::getAnalysisUsage(AU);
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129213.442597.patch
Type: text/x-patch
Size: 421 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220706/a3ff98d8/attachment.bin>
More information about the llvm-commits
mailing list