[PATCH] D129037: [globalisel] Select register bank for DBG_VALUE

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp:732
+            continue;
+          LLT Ty = MRI->getType(Reg);
+          if (!Ty.isValid()) {
----------------
There are 3 cases that I encounter when debuging test case failure.
1. 0 register.
2. physical register.
3. virtual register that has been assigned to a register class.
I changed the code to check Reg.isPhysical(), but I got a failure for the case 3. So I have to check if Ty is valid here.

`DBG_VALUE %0:gpr32, $noreg, !"6", !DIExpression(), debug-location !35; test/CodeGen/AArch64/GlobalISel/arm64-regbankselect.mir:6:1 line no:6`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129037/new/

https://reviews.llvm.org/D129037