[PATCH] D129037: [globalisel] Select register bank for DBG_VALUE

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86RegisterBankInfo.cpp:117
     auto &MO = MI.getOperand(Idx);
-    if (!MO.isReg())
+    if (!MO.isReg() || !MO.getReg())
       OpRegBankIdx[Idx] = PMI_None;
----------------
This scenario can be covered by `test/CodeGen/X86/GlobalISel/x86-calllowering-dbg-trunc.ll`.


================
Comment at: llvm/lib/Target/X86/X86RegisterBankInfo.cpp:133
       continue;
+    if (!MI.getOperand(Idx).getReg())
+      continue;
----------------
This scenario can be covered by `test/CodeGen/X86/GlobalISel/x86-calllowering-dbg-trunc.ll`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129037/new/

https://reviews.llvm.org/D129037