[PATCH] D129025: [SimplifyCFG] Skip hoisting common instructions that return token type

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

In D129025#3631057 <https://reviews.llvm.org/D129025#3631057>, @efriedma wrote:

> I think we need to clarify LangRef if this is illegal in general for tokens in general.  If it is, we need to explain why.  If it isn't, we need an attribute the express the right semantics here.
>
> All LangRef really says at the moment is that a token can't be put behind a phi or select; it doesn't really describe if/when it's legal to merge instructions that produce tokens.

Yes. I also found the token type description could be more clear. I'll send a follow-up LangRef patch to clarify the intent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129025/new/

https://reviews.llvm.org/D129025