[PATCH] D129025: [SimplifyCFG] Skip hoisting common instructions that return token type

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 12:28:18 PDT 2022


efriedma added a comment.

I think we need to clarify LangRef if this is illegal in general for tokens in general.  If it is, we need to explain why.  If it isn't, we need an attribute the express the right semantics here.

All LangRef really says at the moment is that a token can't be put behind a phi or select; it doesn't really describe if/when it's legal to merge instructions that produce tokens.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129025/new/

https://reviews.llvm.org/D129025



More information about the llvm-commits mailing list