[PATCH] D128108: [WIP][lld-macho] Add support for objc_msgSend stubs
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 5 12:32:57 PDT 2022
int3 added inline comments.
================
Comment at: lld/MachO/SyntheticSections.cpp:678
+ // also based on arch seems like?
+ return 32 * symbolsWithOffsets.size(); // fast // TODO: Extract 32 to target
+}
----------------
int3 wrote:
> I would just do an `if` check for 32/64 bit here, I don't think we should having ObjC implementation details exposed on the `Target` class
nvm, I realize this is in line with what we're already doing for the regular stubs code + arch dependency means that we'd need to check for more than word size
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128108/new/
https://reviews.llvm.org/D128108
More information about the llvm-commits
mailing list