[PATCH] D128108: [WIP][lld-macho] Add support for objc_msgSend stubs

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 12:11:54 PDT 2022


int3 added inline comments.


================
Comment at: lld/MachO/Writer.cpp:698-700
+    } else if (const auto *undefined = dyn_cast<Undefined>(sym)) {
+      if (sym->getName().startswith("_objc_msgSend$"))
+        in.objcStubs->addEntry(sym);
----------------
I think this should be part of `treatSpecialUndefineds`, which runs before `scanSymbols` -- I expect that we'd raise undef symbol errors otherwise


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128108/new/

https://reviews.llvm.org/D128108



More information about the llvm-commits mailing list