[PATCH] D129086: [NFC][AMDGPU] Cleanup the SIOptimizeExecMasking pass.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 05:48:53 PDT 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMasking.cpp:744
+
+  Utils = std::make_unique<SIOptimizeExecMaskingUtils>(MF);
+
----------------
I don't understand the value of making this a separate class, instead of part of the main SIOptimizeExecMasking class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129086/new/

https://reviews.llvm.org/D129086



More information about the llvm-commits mailing list