[PATCH] D129086: [NFC][AMDGPU] Cleanup the SIOptimizeExecMasking pass.

[Thomas Symalla via Phabricator via llvm-commits]

tsymalla added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMasking.cpp:55
 
+static MCRegister getExecByWaveMode(const GCNSubtarget &ST) {
+  return ST.isWave32() ? AMDGPU::EXEC_LO : AMDGPU::EXEC;
----------------
nhaehnle wrote:
> foad wrote:
> > Maybe add a new SIRegisterInfo::getEXEC, similar to the existing SIRegisterInfo::getVCC?
> We talked about that a bit offline. I'm partial to having a "LaneMaskConstants" helper that gives access to a whole suite of wave-size dependent constants, i.e. physical register constants but also for the related opcodes.
I decided to go with @foad 's approach for now.
When I start working on the helper you were talking about, I'll clean up the whole codebase, including the now-introduced `getExec()` function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129086/new/

https://reviews.llvm.org/D129086