[PATCH] D129086: [NFC][AMDGPU] Cleanup the SIOptimizeExecMasking pass.

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

I would also suggest turning more static functions into const member functions, so you don't have to keep passing around ST and TRI and MRI and TII...



================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMasking.cpp:55
 
+static MCRegister getExecByWaveMode(const GCNSubtarget &ST) {
+  return ST.isWave32() ? AMDGPU::EXEC_LO : AMDGPU::EXEC;
----------------
Maybe add a new SIRegisterInfo::getEXEC, similar to the existing SIRegisterInfo::getVCC?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129086/new/

https://reviews.llvm.org/D129086