[PATCH] D129075: [AMDGPU] gfx11 allow dlc for MUBUF atomics

[Petar Avramovic via Phabricator via llvm-commits]

Petar.Avramovic added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4486
+  if ((CPol & CPol::DLC) && isGFX10() && (TSFlags & SIInstrFlags::MUBUF)) {
+    SMLoc S = getImmLoc(AMDGPUOperand::ImmTyCPol, Operands);
+    StringRef CStr(S.getPointer());
----------------
foad wrote:
> Do I understand correctly: we don't need to check for isGFX9() here because the DLC bit did not exist on GFX9, so `CPol & CPol::DLC` would always be false?
yes...


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5962-5965
   if (!isGFX10Plus() && ((CPolOn | CPolOff) & AMDGPU::CPol::DLC)) {
     Error(S, "dlc modifier is not supported on this GPU");
     return MatchOperand_ParseFail;
   }
----------------
... gfx9 (and older) check is during parsing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129075/new/

https://reviews.llvm.org/D129075