[PATCH] D129075: [AMDGPU] gfx11 allow dlc for MUBUF atomics

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 4 06:10:01 PDT 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4486
+  if ((CPol & CPol::DLC) && isGFX10() && (TSFlags & SIInstrFlags::MUBUF)) {
+    SMLoc S = getImmLoc(AMDGPUOperand::ImmTyCPol, Operands);
+    StringRef CStr(S.getPointer());
----------------
Do I understand correctly: we don't need to check for isGFX9() here because the DLC bit did not exist on GFX9, so `CPol & CPol::DLC` would always be false?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129075/new/

https://reviews.llvm.org/D129075



More information about the llvm-commits mailing list