[PATCH] D128999: [CGSCC] Don't count calls to intrinsic functions in finding potential deviritualizations.

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 2 10:17:32 PDT 2022


Some intrinsics can be indirect-call targets, like memcpy. My first patch
actually ignored all the intrinsics, but it broke some tests.

On Fri, Jul 1, 2022 at 2:09 PM Nikita Popov via Phabricator <
reviews at reviews.llvm.org> wrote:

> nikic added reviewers: nikic, aeubanks.
> nikic requested changes to this revision.
> nikic added a comment.
> This revision now requires changes to proceed.
>
> I think the general idea behind this change makes sense. However, we
> should be treating all intrinsics the same way here (by skipping them), and
> not special-case assume-like and dbg intrinsics. Intrinsics generally
> cannot be called indirectly (this is enforced by the IR verifier), so they
> are irrelevant for the purposes of devirtualization.
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D128999/new/
>
> https://reviews.llvm.org/D128999
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220702/4c7e3189/attachment.html>


More information about the llvm-commits mailing list