<div dir="ltr"><div>Some intrinsics can be indirect-call targets, like memcpy. My first patch actually ignored all the intrinsics, but it broke some tests.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jul 1, 2022 at 2:09 PM Nikita Popov via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">nikic added reviewers: nikic, aeubanks.<br>
nikic requested changes to this revision.<br>
nikic added a comment.<br>
This revision now requires changes to proceed.<br>
<br>
I think the general idea behind this change makes sense. However, we should be treating all intrinsics the same way here (by skipping them), and not special-case assume-like and dbg intrinsics. Intrinsics generally cannot be called indirectly (this is enforced by the IR verifier), so they are irrelevant for the purposes of devirtualization.<br>
<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D128999/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D128999/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D128999" rel="noreferrer" target="_blank">https://reviews.llvm.org/D128999</a><br>
<br>
</blockquote></div></div>