[PATCH] D126904: [llvm-objdump] Add support for dumping embedded offloading data

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/Offloading/binary.test:1
+## Check to see that we can dump an offloading binary directly.
+# RUN: yaml2obj %S/Inputs/binary.yaml -o %t.bin
----------------
`to see` conveys no information and should be deleted.

ditto elsewhere


================
Comment at: llvm/test/tools/llvm-objdump/Offloading/warning.test:1
+## Check to ensure we give a warning on bad input following good input.
+# RUN: yaml2obj %S/Inputs/binary.yaml -o %t-good.bin
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126904/new/

https://reviews.llvm.org/D126904