[PATCH] D126904: [llvm-objdump] Add support for dumping embedded offloading data

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/OffloadDump.cpp:42
+  outs() << "\nOFFLOADING IMAGE "
+         << "[" << Index << "]:\n";
+  outs() << left_justify("kind", 16) << getImageName(OB) << "\n";
----------------
jhuber6 wrote:
> MaskRay wrote:
> > Append `[` to `OFFLOAD IMAGE`
> Could you elaborate on this? do you want it formatted like `OFFLOADING IMAGE[0]`?
`outs() << "\nOFFLOADING IMAGE [" << Index << "]:\n"`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126904/new/

https://reviews.llvm.org/D126904