[PATCH] D128934: [X86] Add RDPRU instruction
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 30 13:29:30 PDT 2022
probinson marked 2 inline comments as done.
probinson added a comment.
i686 tests added, but I have to leave it to the subject-matter experts whether they are correct.
================
Comment at: llvm/lib/Target/X86/X86InstrSystem.td:742
+let Uses = [ECX], Defs = [EAX, EDX] in
+ def RDPRU : I<0x01, MRM_FD, (outs), (ins), "rdpru", []>, TB,
+ Requires<[HasRDPRU]>;
----------------
craig.topper wrote:
> I think `TB` here should be `PS`. Per table "Table A-8. Opcode 01h ModRM Extensions", the instruction is not valid with a 0xF2 or 0xF3 prefix. `PS` is our marker for that.
Done, but is there a way I should be testing this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128934/new/
https://reviews.llvm.org/D128934
More information about the llvm-commits
mailing list