[PATCH] D128570: [ISel] Round down mask bit when merge undef(s) for DAG combine

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 30 04:01:43 PDT 2022


xiangzhangllvm added a comment.

In D128570#3621731 <https://reviews.llvm.org/D128570#3621731>, @RKSimon wrote:

> Please pre-commit fshl-splat-undef.ll with current trunk codegen so that the patch commit shows the codegen change.
>
> LGTM with a few minors



In D128570#3621731 <https://reviews.llvm.org/D128570#3621731>, @RKSimon wrote:

> Please pre-commit fshl-splat-undef.ll with current trunk codegen so that the patch commit shows the codegen change.
>
> LGTM with a few minors

Sure! Pursuing Perfection : ) Thank you!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128570/new/

https://reviews.llvm.org/D128570



More information about the llvm-commits mailing list