[PATCH] D128875: [RISCV] Precommit testcase to show wrong result of make-compressible optimization

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng created this revision.
Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, arichardson.
Herald added a project: All.
kito-cheng requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

Use following example to demo what happened now:

  li      a1, 1
  sd      a1, 800(a0)
  sd      a0, 808(a0) # Store base address into base + offset
  li      a1, 2
  sd      a1, 816(a0)

Current will optimizate into:

  li      a1, 1
  addi    a2, a0, 768
  sd      a1, 32(a2)
  sd      a2, 40(a2) # Wrong replacement for the source register.
  li      a1, 2
  sd      a1, 48(a2)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D128875

Files:
  llvm/test/CodeGen/RISCV/make-compressible-for-store-address.mir


Index: llvm/test/CodeGen/RISCV/make-compressible-for-store-address.mir
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/RISCV/make-compressible-for-store-address.mir
@@ -0,0 +1,47 @@
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -o - %s -mtriple=riscv64 -mattr=+c -simplify-mir \
+# RUN:   -run-pass=riscv-make-compressible | FileCheck %s
+--- |
+  define void @foo(ptr noundef %ptr) #0 {
+  entry:
+    %0 = ptrtoint ptr %ptr to i64
+    %1 = getelementptr inbounds i64, ptr %ptr, i64 100
+    store i64 1, ptr %1, align 8
+    %2 = getelementptr inbounds i64, ptr %ptr, i64 101
+    store i64 %0, ptr %2, align 8
+    %3 = getelementptr inbounds i64, ptr %ptr, i64 102
+    store i64 2, ptr %3, align 8
+    ret void
+  }
+
+  attributes #0 = { minsize }
+
+...
+---
+name:            foo
+alignment:       2
+tracksRegLiveness: true
+liveins:
+  - { reg: '$x10' }
+body:             |
+  bb.0.entry:
+    liveins: $x10
+
+    ; CHECK-LABEL: name: foo
+    ; CHECK: liveins: $x10
+    ; CHECK-NEXT: {{  $}}
+    ; CHECK-NEXT: renamable $x11 = ADDI $x0, 1
+    ; CHECK-NEXT: $x12 = ADDI $x10, 768
+    ; CHECK-NEXT: SD killed renamable $x11, $x12, 32 :: (store (s64) into %ir.1)
+    ; CHECK-NEXT: SD $x12, $x12, 40 :: (store (s64) into %ir.2)
+    ; CHECK-NEXT: renamable $x11 = ADDI $x0, 2
+    ; CHECK-NEXT: SD killed renamable $x11, killed $x12, 48 :: (store (s64) into %ir.3)
+    ; CHECK-NEXT: PseudoRET
+    renamable $x11 = ADDI $x0, 1
+    SD killed renamable $x11, renamable $x10, 800 :: (store (s64) into %ir.1)
+    SD renamable $x10, renamable $x10, 808 :: (store (s64) into %ir.2)
+    renamable $x11 = ADDI $x0, 2
+    SD killed renamable $x11, killed renamable $x10, 816 :: (store (s64) into %ir.3)
+    PseudoRET
+
+...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128875.441262.patch
Type: text/x-patch
Size: 1838 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220630/8317e1fa/attachment.bin>