[PATCH] D128741: [RISCV] Fold (add X, [-4096, -2049]) or (add X, [2048,4096]) into load/store address during isel.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 11:47:24 PDT 2022


asb added a comment.

In D128741#3616350 <https://reviews.llvm.org/D128741#3616350>, @craig.topper wrote:

> In D128741#3616256 <https://reviews.llvm.org/D128741#3616256>, @reames wrote:
>
>> Code is fine, but no tests?
>
> I don't have a good way to show the change. The post-isel peephole already cleans this up. This is matching it earlier. I'm trying to remove the post-isel peephole.

So is this patch going to be updated to also remove the peephole?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128741/new/

https://reviews.llvm.org/D128741



More information about the llvm-commits mailing list