[PATCH] D128626: [llvm-ar] Add --output to specify output directory

Owen Reynolds via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 27 02:40:06 PDT 2022


gbreynoo added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/extract.test:51
+# RUN: not llvm-ar rc --output=dir %t/archive.a %t/a.txt 2>&1 | FileCheck %s --check-prefix=OUTPUT-ERR
+# OUTPUT-ERR: error: --output is only applicable to the 'x' operation
----------------
I think it would be worth adding a test case for if the given output location does not exist.


================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:94
   @<file>               - read options from <file>
 
 OPERATIONS:
----------------
--output needs adding to the help text.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128626/new/

https://reviews.llvm.org/D128626



More information about the llvm-commits mailing list