[PATCH] D128626: [llvm-ar] Add --output to specify output directory

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 27 02:25:32 PDT 2022


jhenderson added a comment.

I'm uncertain, but should we have a test case where the output directory doesn't exist?



================
Comment at: llvm/docs/CommandGuide/llvm-ar.rst:279
+
+ Specify a directory where archive members should be extracted. By default the
+ current working directory is used.
----------------



================
Comment at: llvm/test/tools/llvm-ar/extract.test:38
+
+## --output specifies the directory to extract archive members.
+# RUN: mkdir %t/extracted/dir
----------------



================
Comment at: llvm/test/tools/llvm-ar/extract.test:44
+
+## Test --output with an absolute path after the operation.
+# RUN: rm -f %t/extracted/dir/a.txt
----------------
I'm not sure what "after the operation" here means?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128626/new/

https://reviews.llvm.org/D128626



More information about the llvm-commits mailing list