[PATCH] D127083: [MCA] Introducing incremental SourceMgr and resumable pipeline

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/unittests/tools/llvm-mca/X86/CMakeLists.txt:3
+  ${LLVM_MAIN_SRC_DIR}/lib/Target/X86
+  ${LLVM_BINARY_DIR}/lib/Target/X86
+  )
----------------
(But, similar to the llvm-exegesis tests, it's weird that this depends on internals of the X86 target. llvm-exegesis "at least" makes this choice at the tool level, but here it's only the test that does this. Is there a way to instead use the public API instead of depending on internal headers of lib/Target/X86?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127083/new/

https://reviews.llvm.org/D127083