[PATCH] D127083: [MCA] Introducing incremental SourceMgr and resumable pipeline

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/unittests/tools/llvm-mca/CMakeLists.txt:26
+
+function(add_llvm_mca_unittest_includes)
+  set(mca_includes ${mca_includes} ${ARGV} PARENT_SCOPE)
----------------
thakis wrote:
> Why is this file so complicated? All other CMakeLists.txt in llvm/unittests are very simple.
> 
> It kind of looks like this links in some, but not all, code in tools/llvm-mca/Views in to the test, instead of doing a library-level dependency. That seems
> a) strange from a layering PoV
> b) ODR-violation-prone in the future
> 
> Why is this designed the way it is, instead of more like all the other tests?
For example, the llvm/unittests/tools/llvm-exegesis/* does something somewhat similar (…I think?) with much less machinery, by having a test binary per target. Could that design work here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127083/new/

https://reviews.llvm.org/D127083