[PATCH] D127554: [PowerPC] Allow llvm.ppc.cfence to accept pointer types

[Kai Luo via Phabricator via llvm-commits]

lkail added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/cfence-double.ll:7
 
-; CHECK: Intrinsic has incorrect argument type!
-; CHECK: ptr @llvm.ppc.cfence.f64
+; CHECK: Assertion `VT.isInteger() && Operand.getValueType().isInteger() && "Invalid ANY_EXTEND!"' failed
+
----------------
lkail wrote:
> nemanjai wrote:
> > Is the plan here to do something better than assert? Perhaps emit a fatal error? What happens on non-assert builds on these tests now? Something terrible?
> I've posted https://reviews.llvm.org/D127563 to fix cfence on floating point types on PowerPC side. Alternative solution would be https://reviews.llvm.org/D127609(since the solution on PowerPC side assumes the floating point value is converted from integer value). For non-assert builds, the test causes an ICE.
The ICE is something like
```
LLVM ERROR: Cannot select: 0x6534da8: i64 = any_extend 0x6534b38
  0x6534b38: f64 = bitcast 0x6534ad0
    0x6534ad0: i64,ch = AtomicLoad<(load monotonic (s64) from %ir.0)> 0x64befe8, 0x6534a68
      0x6534a68: i64,ch = CopyFromReg 0x64befe8, Register:i64 %0
        0x6534a00: i64 = Register %0
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127554/new/

https://reviews.llvm.org/D127554