[PATCH] D127554: [PowerPC] Allow llvm.ppc.cfence to accept pointer types

Fri Jun 24 02:00:24 PDT 2022

lkail added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/cfence-double.ll:7

-; CHECK: Intrinsic has incorrect argument type!
-; CHECK: ptr @llvm.ppc.cfence.f64
+; CHECK: Assertion `VT.isInteger() && Operand.getValueType().isInteger() && "Invalid ANY_EXTEND!"' failed
+
----------------
nemanjai wrote:
> Is the plan here to do something better than assert? Perhaps emit a fatal error? What happens on non-assert builds on these tests now? Something terrible?
I've posted https://reviews.llvm.org/D127563 to fix cfence on floating point types on PowerPC side. Alternative solution would be https://reviews.llvm.org/D127609(since the solution on PowerPC side assumes the floating point value is converted from integer value). For non-assert builds, the test causes an ICE.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127554/new/

https://reviews.llvm.org/D127554