[PATCH] D128082: [BOLT][AArch64] Handle gold linker veneers

[Vladislav Khmelevsky via Phabricator via llvm-commits]

yota9 marked 3 inline comments as done.
yota9 added inline comments.


================
Comment at: bolt/test/AArch64/veneer.s:12
+.text
+.align 2
+.global foo
----------------
maksfb wrote:
> Why is it `.align 2`? I though AArch64 required 4 bytes.
It's 1 << 2 = 4 bytes


================
Comment at: bolt/test/AArch64/veneer.s:31
+_start:
+# CHECK: {{.*}} bl {{.*}} <foo>
+  bl myveneer
----------------
maksfb wrote:
> Will be also good to check the input, to make sure the linker respects `--no-relax`. Alternatively, print the function in BOLT before and after the veneer elimination pass.
NP :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128082/new/

https://reviews.llvm.org/D128082