[PATCH] D128082: [BOLT][AArch64] Handle gold linker veneers

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added inline comments.


================
Comment at: bolt/test/AArch64/veneer.s:8
+# RUN:    -fuse-ld=lld -Wl,--no-relax
+# RUN: llvm-bolt %t.exe -o %t.bolt -elim-link-veneers=true --lite=0
+# RUN: llvm-objdump -d --disassemble-symbols='_start' %t.bolt | FileCheck %s
----------------
We don't enforce double dash long options (at least not yet), but encourage.


================
Comment at: bolt/test/AArch64/veneer.s:12
+.text
+.align 2
+.global foo
----------------
Why is it `.align 2`? I though AArch64 required 4 bytes.


================
Comment at: bolt/test/AArch64/veneer.s:31
+_start:
+# CHECK: {{.*}} bl {{.*}} <foo>
+  bl myveneer
----------------
Will be also good to check the input, to make sure the linker respects `--no-relax`. Alternatively, print the function in BOLT before and after the veneer elimination pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128082/new/

https://reviews.llvm.org/D128082