[PATCH] D125680: Correctly legalise stackmap operands

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 23 06:12:43 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/X86/selectiondag-stackmap-legalize.ll:83
+    half %halfreg,
+    i128 66)
+  ret i32 0
----------------
For a general test, a non-register argument may be more helpful


================
Comment at: llvm/test/CodeGen/X86/selectiondag-stackmap-legalize.ll:84
+    i128 66)
+  ret i32 0
+}
----------------
Is it worth testing vectors?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125680/new/

https://reviews.llvm.org/D125680



More information about the llvm-commits mailing list