[PATCH] D125680: Correctly legalise stackmap operands

Edd Barrett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 06:33:26 PDT 2022


vext01 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:2920
+    Res = SoftPromoteHalfOp_STACKMAP(N, OpNo);
+    break;
   }
----------------
vext01 wrote:
> dantrushin wrote:
> > Nit: could you have it in single line as cases above (if it fits in 80 chars)?
> I think `git clang-format` wanted it this way, but I will check.
Yep. If I fold the lines, then `git clang-format` just undoes it. Should I override it in this instance, or?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125680/new/

https://reviews.llvm.org/D125680



More information about the llvm-commits mailing list